fix: handle declined and error states in grant interaction page#654
Open
Onyx2406 wants to merge 1 commit intointerledger:mainfrom
Open
fix: handle declined and error states in grant interaction page#654Onyx2406 wants to merge 1 commit intointerledger:mainfrom
Onyx2406 wants to merge 1 commit intointerledger:mainfrom
Conversation
The grant interaction page (payment-confirmation.tsx) previously showed the success UI with a green checkmark for all states, including declined grants and server errors. Users saw "Payment Complete!" even when their grant was rejected. Changes: - Check the `result` query parameter for interaction outcome (grant_rejected, etc.) and display appropriate error UI - Use the loader's `success` field to conditionally render success or error state with distinct icons and messaging - Rename the component from PaymentComplete to GrantInteraction to better reflect its purpose - Display the specific error message from the loader Closes interledger#480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the grant interaction page showing success UI for all states, including failures.
Before: Declined grants and errors showed a green checkmark with "Payment Complete!" — misleading.
After:
result=grant_rejected) → red X, "Interaction Failed" with "The grant request was declined."Also renames the component from
PaymentCompletetoGrantInteractionto better reflect its purpose.Changes
frontend/app/routes/payment-confirmation.tsxCloses #480