refactor(widget): centralize interaction view state in InteractionView#656
Open
kjmitchelljr wants to merge 1 commit intomainfrom
Open
refactor(widget): centralize interaction view state in InteractionView#656kjmitchelljr wants to merge 1 commit intomainfrom
kjmitchelljr wants to merge 1 commit intomainfrom
Conversation
Deployment results
Logs #24062400921 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the widget payment interaction screen so all views share one rendering path
What changed
resolveInteractionView()mapscurrentViewto correct viewrenderInteractionView(view)renders the shared layout onceCloses #481
Follow-up: automated tests
I'm still working to add automated tests for this flow, but as I was going through I wondered what would be best approach. Adding unit tests to perform in isolation or begin to build out E2E tests to test out whole payment flow which may be too much overhead at this point. But could have a starting point