Conversation
# Conflicts: # pnpm-lock.yaml
# Conflicts: # pnpm-lock.yaml
# Conflicts: # bruno/collections/Rafiki/environments/Local Playground.bru
❌ Deploy Preview for brilliant-pasca-3e80ec failed. Why did it fail? →
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+331
to
+366
| app.post('/hsm/verify-pin', async function handler(ffReq, ffReply) { | ||
| const requestBody = JSON.parse(JSON.stringify(ffReq.body)) | ||
| const { pinBlock, pan, format, expectedPin, pinEncryptionKey } = requestBody | ||
|
|
||
| try { | ||
| // Validate input | ||
| if (!pinBlock || !pan || !format || !expectedPin) { | ||
| throw new Error('Missing required parameters') | ||
| } | ||
|
|
||
| if (format !== 'ISO-0' && format !== 'ISO-1') { | ||
| throw new Error('Format must be ISO-0 or ISO-1') | ||
| } | ||
|
|
||
| // Verify the PIN | ||
| const isValid = verifyPin( | ||
| pinBlock, | ||
| pan, | ||
| format, | ||
| expectedPin, | ||
| pinEncryptionKey | ||
| ) | ||
|
|
||
| logger.info(`PIN verification result: ${isValid ? 'Valid' : 'Invalid'}`) | ||
|
|
||
| ffReply.code(200).send({ | ||
| isValid, | ||
| format | ||
| }) | ||
| } catch (error) { | ||
| logger.error(`PIN verification error: ${error.message}`) | ||
| ffReply.code(400).send({ | ||
| error: error.message | ||
| }) | ||
| } | ||
| }) |
Check failure
Code scanning / CodeQL
Missing rate limiting High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 months ago
To fix this problem, a rate-limiting middleware should be applied to the /hsm/verify-pin endpoint. Since this is a Fastify application rather than Express, the correct approach is to use the @fastify/rate-limit plugin, which works similarly to the rate limiter shown in the CodeQL example (which used express-rate-limit). This involves:
- Adding an import (or require) for
@fastify/rate-limit. - Registering the plugin on the Fastify app instance (
app), either globally or with route-specific overrides. - For minimal impact, apply a sensible rate limit to the
/hsm/verify-pinroute only, so that other routes remain unaffected.
The best practice is to register the rate-limit plugin once with global options, but then supply more restrictive per-route overrides if desired. Here we'll register the plugin at the start of the createApp function and apply it specifically to the /hsm/verify-pin route via the route's config property.
What needs to be changed:
- Import
@fastify/rate-limit - Register the rate limit plugin
- Add rate limit options SPECIFICALLY for the verify-pin route
Suggested changeset
2
test/hsm-emulator/src/app.ts
| @@ -1,5 +1,6 @@ | ||
| import fastify from 'fastify' | ||
| import logger from './logger' | ||
| import rateLimit from '@fastify/rate-limit' | ||
| import { | ||
| AES_AUSTRIA_CARD_LMK_HEX, | ||
| AES_CUSTOMER_ASE_LMK_HEX, | ||
| @@ -23,6 +24,12 @@ | ||
| export function createApp(port: number) { | ||
| const app = fastify() | ||
|
|
||
| // Register @fastify/rate-limit plugin | ||
| // It's safe to register it globally, but we can override per-route configs below | ||
| app.register(rateLimit, { | ||
| global: false, // We'll enable only per-route | ||
| }) | ||
|
|
||
| app.post( | ||
| '/hsm/ase-customer/generate-zmk', | ||
| async function handler(ffReq, ffReply) { | ||
| @@ -309,7 +316,14 @@ | ||
| }) | ||
|
|
||
| // Add PIN verification endpoint | ||
| app.post('/hsm/verify-pin', async function handler(ffReq, ffReply) { | ||
| app.post('/hsm/verify-pin', { | ||
| config: { | ||
| rateLimit: { | ||
| max: 5, | ||
| timeWindow: '1 minute' | ||
| } | ||
| } | ||
| }, async function handler(ffReq, ffReply) { | ||
| const requestBody = JSON.parse(JSON.stringify(ffReq.body)) | ||
| const { | ||
| pinBlock, |
test/hsm-emulator/package.json
Outside changed files
| @@ -14,7 +14,8 @@ | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "fastify": "^5.2.1", | ||
| "pino": "^9.6.0" | ||
| "pino": "^9.6.0", | ||
| "@fastify/rate-limit": "^10.3.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^20.0.0", |
This fix introduces these dependencies
| Package | Version | Security advisories |
| @fastify/rate-limit (npm) | 10.3.0 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
# Conflicts: # pnpm-lock.yaml
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
# Conflicts: # pnpm-lock.yaml
Contributor
|
@koekiebox closing this, as it seems like it is not relevant given the ongoing card & POS work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Checklist
fixes #numberuser-docslabel (if necessary)