Skip to content

fix: redesign admin ui#3793

Open
JonathanMatthey wants to merge 48 commits intomainfrom
jm/admin-redesign-radix-themes
Open

fix: redesign admin ui#3793
JonathanMatthey wants to merge 48 commits intomainfrom
jm/admin-redesign-radix-themes

Conversation

@JonathanMatthey
Copy link
Copy Markdown
Contributor

Please go to the Preview tab and select the appropriate sub-template:

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 8, 2026

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 33e28cd
🔍 Latest deploy log https://app.netlify.com/projects/brilliant-pasca-3e80ec/deploys/69fa47d9b080c8000846df20

@github-actions github-actions Bot added the pkg: frontend Changes in the frontend package. label Jan 8, 2026
@JonathanMatthey JonathanMatthey marked this pull request as ready for review January 12, 2026 15:36
Copy link
Copy Markdown
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I will ask the team for further reviews

Comment thread packages/frontend/app/routes/wallet-addresses.$walletAddressId.tsx Outdated
Comment thread packages/frontend/app/routes/wallet-addresses.$walletAddressId.tsx Outdated
Comment thread packages/frontend/app/routes/_index.tsx Outdated
Comment thread packages/frontend/app/root.tsx Outdated
Copy link
Copy Markdown
Contributor

@BlairCurrey BlairCurrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. Much improved.

I will also +1 Max's suggestion on the background #3793 (comment)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not just specific to this file, but noticed it here.

If you search for <h1 or 2,3,4 you see we still use the raw html headings in places. Should we make all of those use radix <Heading>?

<Card className='max-w-3xl'>
<Flex direction='column' gap='4'>
<Flex align='center' justify='between' gap='3' wrap='wrap'>
<Text className='rt-Text rt-r-size-2 rt-r-weight-medium uppercase tracking-wide text-gray-600 font-semibold'>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making these section titles <Heading>s? Maybe a small thing but I think it's more semantic and matches what it was previously.

Comment thread packages/frontend/app/root.tsx Outdated
Comment on lines +123 to +128
className='h-full bg-polkadot bg-cover bg-no-repeat bg-center bg-fixed'
className='h-full'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like it's missing something without the polka dot background.

Image

Needs something IMO. bg-diagonal almost feels too light because the content is pretty much just in the white part.

@JonathanMatthey JonathanMatthey self-assigned this Feb 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 47.32
  • Iterations/s: 15.77
  • Failed Requests: 0.00% (0 of 2848)
📜 Logs

> performance@1.0.0 run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test -k -q --vus 4 --duration 1m

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 1.0 MB 17 kB/s
     data_sent......................: 2.2 MB 36 kB/s
     http_req_blocked...............: avg=7.36µs   min=1.82µs  med=5.67µs  max=690.63µs p(90)=6.89µs   p(95)=7.51µs  
     http_req_connecting............: avg=349ns    min=0s      med=0s      max=381.17µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=83.88ms  min=7.53ms  med=68.67ms max=390ms    p(90)=141.12ms p(95)=165.35ms
       { expected_response:true }...: avg=83.88ms  min=7.53ms  med=68.67ms max=390ms    p(90)=141.12ms p(95)=165.35ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2848
     http_req_receiving.............: avg=94.06µs  min=28.04µs med=85.62µs max=2ms      p(90)=121.77µs p(95)=149.39µs
     http_req_sending...............: avg=37.04µs  min=9.86µs  med=29.51µs max=1.21ms   p(90)=44.32µs  p(95)=58.1µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=83.75ms  min=7.35ms  med=68.5ms  max=389.88ms p(90)=140.95ms p(95)=165.25ms
     http_reqs......................: 2848   47.322255/s
     iteration_duration.............: avg=253.38ms min=174.1ms med=239.8ms max=802.16ms p(90)=321.33ms p(95)=350.71ms
     iterations.....................: 949    15.768547/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@JonathanMatthey
Copy link
Copy Markdown
Contributor Author

@BlairCurrey addressed all the feedback, if you can have 1 more look please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: frontend Changes in the frontend package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants