-
Notifications
You must be signed in to change notification settings - Fork 19
Fix various issues with installation of CamCHILDMine #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix various issues with installation of CamCHILDMine #17
Conversation
They are getting truncated
Not the permanent solution. This should be ignored if biotestmine is not being used
There are permissions problems if we try to use a different user
Don't try to do anything with the Solr UID/GID
cargoDeployRemote fails if run for a second time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it look good to me.
@heralden please have a look as well. This PR introduces some |
In case it may be of use, we found another workaround for this issue is to ensure the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the very late review.
This project is only used as a git submodule in https://github.com/intermine/intermine_boot and neither are depended on for active deployments of intermine. Hence it should be safe to make drastic changes to this repo and various improvements. Please go ahead and merge this, and if you want to make further improvements, I'm fine with those getting merged as well without my review.
In the process of getting the 2022 FAIR TREATMENT (CamCHILDMine) demo working I ended up making these changes. In summary:
version
from docker compose YAML filesbuild.sh
if any part of the script fails unexpectedly.env
filemalaria-data.tar.gz
if it is not presentgradlew cargoDeployRemote
. In CamCHILDMine I've implemented the workaround described in Gradle needs to start or deploy a second time to serve webapp intermine#2162 (comment)local.docker-compose.yml
. I've removed the parsing of the YAML file inmkdatadirs.sh
as this seemed like a brittle approach and made this script runnable from anywhere.There was a bit of guesswork involved so I'd appreciate another set of eyes on this.