Lists.parseListCreationInfo throws JSONException if unmatched identifiers are not strings#7
Open
jtnystrom wants to merge 2 commits intointermine:masterfrom
Open
Lists.parseListCreationInfo throws JSONException if unmatched identifiers are not strings#7jtnystrom wants to merge 2 commits intointermine:masterfrom
jtnystrom wants to merge 2 commits intointermine:masterfrom
Conversation
…matched identifiers are sometimes integers, not strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone, thanks for your work on Intermine. I found what I think is a bug in the Java client library and thought I would try to contribute a fix.
During list creation, if some unmatched identifiers are integers, which can happen if a list is specified using Entrez gene IDs, then we can have
which causes ServiceException at:
caused by
The attached change to Lists here (optString(0) instead of getString(0)) fixes this and should not affect the case where the item is a String.
I have tested this with my application and confirmed that it works, but unfortunately I wasn't able to run the intermine-ws-java test suite.