Add dockable slider, left/right buttons #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezvi
force-pushed
the
br-7409-mobile-page-numbers
branch
3 times, most recently
from
7206210 to
eefd1e1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1441 +/- ##
==========================================
- Coverage 69.56% 69.48% -0.08%
==========================================
Files 62 62
Lines 5313 5306 -7
Branches 1156 1149 -7
==========================================
- Hits 3696 3687 -9
- Misses 1584 1585 +1
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pezvi
force-pushed
the
br-7409-mobile-page-numbers
branch
from
eefd1e1 to
0927903
Compare
pezvi
force-pushed
the
br-7409-mobile-page-numbers
branch
from
0927903 to
604fa29
Compare
pezvi
force-pushed
the
br-7409-mobile-page-numbers
branch
2 times, most recently
from
6d0fe96 to
643d820
Compare
- Returns to one format for page numbers at all breakpoints - Removes slider and left/right from main navbar at mobile breakpoints - Adds toggle-slider button to main navbar at mobile breakpoints - Adds new dockable mobile navbar with slider and left/right buttons - Anchors searchNavigation to the Desktop nav - Adjusts E2E tests
pezvi
force-pushed
the
br-7409-mobile-page-numbers
branch
from
643d820 to
c250c1c
Compare
pezvi
changed the title
cdrini
approved these changes
Nov 25, 2025
Contributor
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Niiiice this looks fantastic Jim! I tested on FF/Chrome+Windows, Chrome+Android, iOS (BrowserStack), across a few view modes/searches/TOCs, and everything worked smoothly! Although I think the 1px height is visually inaccessible to me ; can we make that 2px? I note in the CSS it has a height of 2px; I think it's the top that's causing it to be 1px.
Otherwise lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.