Fix Issue #1474: Initialize br.book Before Plugins to Prevent Startup Errors#1507
Open
manikyarathore wants to merge 3 commits intointernetarchive:masterfrom
Open
Fix Issue #1474: Initialize br.book Before Plugins to Prevent Startup Errors#1507manikyarathore wants to merge 3 commits intointernetarchive:masterfrom
manikyarathore wants to merge 3 commits intointernetarchive:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the BookReader demo would throw an error when reduceSet
was invalid or undefined, causing the viewer to fail to load properly.
This commit ensures that reduceSet is checked and handled before
plugin initialization, preventing runtime errors. Verified that the
BookReader demo now loads correctly with all controls functional.
Screenshot attached showing the demo working without errors.