Skip to content

draft: add Thorium support #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
galgeek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

draft: add Thorium support #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion brozzler/chrome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def check_version(chrome_exe):
# Chromium 61.0.3163.100 Built on Ubuntu , running on Ubuntu 16.04
cmd = [chrome_exe, '--version']
out = subprocess.check_output(cmd, timeout=60)
m = re.search(br'(Chromium|Google Chrome) ([\d.]+)', out)
m = re.search(br'(Chromium|Google Chrome|Thorium) ([\d.]+)', out)
if not m:
sys.exit(
'unable to parse browser version from output of '
Expand Down
1 change: 1 addition & 0 deletions brozzler/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def configure_logging(args):
def suggest_default_chrome_exe():
# mac os x application executable paths
for path in [
'/Applications/Thorium.app/Contents/MacOS/Thorium',
'/Applications/Chromium.app/Contents/MacOS/Chromium',
'/Applications/Google Chrome.app/Contents/MacOS/Google Chrome']:
if os.path.exists(path):
Expand Down