Skip to content

feat: add behavior status response to logging #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adam-miller wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add behavior status response to logging #313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f12451b
feat: add behavior status response to logging
adam-miller Jan 6, 2025
4310912
chore: Add timing information to behavior exit log
adam-miller Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion brozzler/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,12 @@ def run_behavior(self, behavior_script, timeout=900):
lambda: self.websock_thread.received_result(msg_id), timeout=5
)
msg = self.websock_thread.pop_result(msg_id)

self.logger.info("Behavior status is %s", str(msg))
# Behavior response while still running
# {'id': 8, 'result': {'result': {'type': 'boolean', 'value': False}}}
# Behavior response when finished
# {'id': 9, 'result': {'result': {'type': 'boolean', 'value': True}}}
if (
msg
and "result" in msg
Expand All @@ -818,7 +824,10 @@ def run_behavior(self, behavior_script, timeout=900):
and type(msg["result"]["result"]["value"]) == bool
and msg["result"]["result"]["value"]
):
self.logger.info("behavior decided it has finished")
self.logger.info(
"behavior decided it has finished after %.1fs",
time.time() - start,
)
return
except BrowsingTimeout:
pass
Expand Down