Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions brozzler/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,9 @@ def __str__(self):
def note_redirect(self, url):
self.redirect_url = url

def clear_redirect(self):
self.redirect_url = None

def _calc_priority(self):
if not self.url:
return None
Expand Down
1 change: 1 addition & 0 deletions brozzler/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,7 @@ def _on_service_worker_version_updated(chrome_msg):
window_width=self._window_width,
headless=self._headless,
)
page.clear_redirect()
final_page_url, outlinks = browser.browse_page(
page.url,
extra_headers=site.extra_headers(page),
Expand Down
15 changes: 15 additions & 0 deletions tests/test_brozzling.py
Original file line number Diff line number Diff line change
Expand Up @@ -398,3 +398,18 @@ def test_network_monitoring(httpd):
# 3 second request + 2 seconds idle = 5 seconds
elapsed = time.time() - start
assert 5 < elapsed < 6


def test_chrome_error(httpd):
chrome_exe = brozzler.suggest_default_chrome_exe()
url = "http://nonexistent.invalid"
worker = brozzler.BrozzlerWorker(None)
site = brozzler.Site(None, {})
page = brozzler.Page(None, {"url": url})
with brozzler.Browser(chrome_exe=chrome_exe) as browser:
with pytest.raises(brozzler.PageConnectionError):
worker.brozzle_page(browser, site, page)
assert page.redirect_url and page.redirect_url.startswith("chrome-error:")
page.url = "http://localhost:%s/site1/" % httpd.server_port
worker.brozzle_page(browser, site, page)
assert not (page.redirect_url and page.redirect_url.startswith("chrome-error:"))