Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new warc concat subcommand to combine multiple WARC files into a single output file, with optional deletion of the original inputs.
Changes:
- Register a new
concatCobra subcommand in thewarcCLI. - Implement byte-level concatenation of multiple input files into a single output file.
- Add a safety check to refuse concatenation of gowarc zstd dictionary-frame files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| cmd/warc/main.go | Registers the new concat subcommand on the root CLI. |
| cmd/warc/concat/concat.go | Implements concatenation, logging, dictionary-frame detection, and optional input deletion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
IIRC, WARC Spec allows you to directly concat multiple warc files without rewriting the warc records? ( |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@yzqzss Yes! We just wanted a convenient way to accomplish WARC concatenation within existing toolset |
NGTmeaty
left a comment
There was a problem hiding this comment.
Changes look good to me!
No description provided.