907 refactor wayback search a11y#912
Open
krisztin wants to merge 5 commits intointernetarchive:masterfrom
Open
907 refactor wayback search a11y#912krisztin wants to merge 5 commits intointernetarchive:masterfrom
krisztin wants to merge 5 commits intointernetarchive:masterfrom
Conversation
To comply with WCAG 2.2 Success Criterion 1.1.1 Non-text Content, specifically decoration, as icon-search.js does not serve any functional purpose it needs to have the attribute aria-hidden="true" so it can be ignored by assistive technology and focusable="false" (for IE backwards compatibility).
To comply with WCAG 2.2 Success Criterion 1.1.1 Non-text Content, specifically decoration the svg logo itself needs an aria-hidden="true" attribute (focusable=false is added for IE compatibility) so that it can be ignored by assistive technology as it adds no useful context. The only thing necessary is an aria-label on the anchor tag.
There were a few accessibility issues with the search field: - Fieldset was used unnecessarily/improperly. - The search label was on display:none which would make it invisible for screen readers as well.
1. Text colour was #858585 on #eee background which has a 3.18:1 contrast ratio failing WCAG AA for normal text. Sufficient contrast needed to be achieved. New contrast ratio is 21:1 passing both AA and AAA requirements. 2. Contrast between the input's background (used to be #eee, now #fff) and the parent elements background (#FCF5E6) is insufficient (only 1.08:1), making the input a very difficult target for clicking for the visually impaired.
By matching the border-radius of the input and parent element we can achieve a more visually harmonious design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #907
Testing
Give it a whirl with a screen reader (i.e. NVDA or JAWS). For contrast issues see WebAim's contrast checker
Evidence