check auth token when getting user#273
Open
RayBB wants to merge 1 commit intointernetarchive:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocking: internetarchive/openlibrary#11815
Before this pull request, when fetching a user we first checked whether a cookie was set. The purpose of that check wasn’t to use the cookie itself, but simply to avoid making a user request when no authentication information was present.
In practice, though, we never use the cookie after that check. Authentication actually relies on an auth token that’s already attached to the connection, and that token may have originally come from a cookie earlier in the flow.
This becomes a problem in the FastAPI code path: web.cookie is not set there, so the cookie check fails, even though the auth token is present and valid.