Update author/import models#419
Open
pidgezero-one wants to merge 4 commits intointernetarchive:masterfrom
Open
Update author/import models#419pidgezero-one wants to merge 4 commits intointernetarchive:masterfrom
pidgezero-one wants to merge 4 commits intointernetarchive:masterfrom
Conversation
This was referenced Nov 27, 2024
Closed
Freso
suggested changes
Dec 6, 2024
Freso
left a comment
Freso
left a comment
There was a problem hiding this comment.
This looks great! One small omission I noted, otherwise this seems perfect to me. Thank you for making this, and sorry for taking so long to come around to look at it proper. :)
Not sure if olclient/schemata/author.schema.json should be updated together with the import schema, but I’ll leave that for someone else to decide. (I’m very partial to splitting up changes as much as possible, but I’m not the one “running” this codebase. 😅 )
Co-authored-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Author
|
@Freso No problem at all, thank you for the suggestion! That's a good call, I can update this PR to call those out more specifically, since the feature is still up for debate anyway. 😄 |
…'s not the point of this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes internetarchive/openlibrary#9448
Companion PR to internetarchive/openlibrary#10110
todo: change this to the example in internetarchive/openlibrary#9448?
Description:
Adds descriptive strong identifiers to the author model and defines those identifiers in the author import model.
Stakeholders:
@Freso