(RUF012) Fixed mutable class Defaults- Task 1 #10278#10281
Closed
ananyakaligal wants to merge 9 commits intointernetarchive:masterfrom
Closed
(RUF012) Fixed mutable class Defaults- Task 1 #10278#10281ananyakaligal wants to merge 9 commits intointernetarchive:masterfrom
ananyakaligal wants to merge 9 commits intointernetarchive:masterfrom
Conversation
added 3 commits
January 5, 2025 23:19
for more information, see https://pre-commit.ci
RayBB
requested changes
Jan 5, 2025
Collaborator
RayBB
left a comment
There was a problem hiding this comment.
Remove unnecessary navigation changes.
Make sure python tests are passing.
Then you can make this as not draft and tag me.
Thanks!
24 tasks
Author
|
yes, working on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10196
Technical
Testing
Ran ruff check --select RUF012 to confirm no further warnings.
Stakeholders
@RayBB