Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames references from analytics.js to athena.js for improved clarity and consistency.
- Updated script source in footer.html and removed outdated comment
- Modified regex in service-worker-matchers.js and code.py to reflect the new name
- Adjusted header documentation in ol.analytics.js to indicate dependency on athena.js
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openlibrary/templates/site/footer.html | Updated script source and removed legacy comment |
| openlibrary/plugins/openlibrary/js/service-worker-matchers.js | Replaced analytics.js with athena.js in the regex |
| openlibrary/plugins/openlibrary/js/ol.analytics.js | Updated header comment to refer to athena.js |
| openlibrary/plugins/openlibrary/code.py | Modified regex pattern to match athena.js instead of analytics.js |
cdrini
approved these changes
May 27, 2025
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Confirmed analytics works; lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes WEBDEV-6982; 1-off by @bfalling
renamed analytics.js to athena.js
Technical
Testing
Screenshot
Stakeholders