Skip to content

upgrade to eslint v9#10850

Draft
RayBB wants to merge 19 commits intomasterfrom
upgrade-eslint-v9
Draft

upgrade to eslint v9#10850
RayBB wants to merge 19 commits intomasterfrom
upgrade-eslint-v9

Conversation

@RayBB
Copy link
Collaborator

@RayBB RayBB commented May 23, 2025

Closes #10805

TODO:

  • Get pre-commit working. No idea why npm command works but not pre-commit
    • Partially Fixed by installing @eslint/js which is used by the new config
  • Get the tests directory working, will need some special config.

Technical

It seems pre-commit and eslint and node modules don't work well together. So it's in a bash script now.
See:

Testing

Screenshot

Stakeholders

@cdrini
Copy link
Collaborator

cdrini commented May 28, 2025

Chatted with @RayBB , this has become tricky! Having different flows for how eslint runs in CI vs locally would be a bit frustrating to maintain; hopefully one of the other repos has an idea/solution! Otherwise I think sticking with the older eslint for now might be good enough. I'm sure they'll sort it out eventually, at which point we can update 😁 In the mean time, it might be worth look at oxc; that's a newer player in this space, not sure if it can do everything we're using eslint for, but might be worth a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants