Skip to content

Fix: Allow redirected authors in validation #11393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAYAN02-DEV wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Allow redirected authors in validation #11393

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cda0d16
Fix: Allow redirected authors in validation
SAYAN02-DEV Oct 30, 2025
61e4f05
Fix: Allow redirected authors in validation
SAYAN02-DEV Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openlibrary/plugins/openlibrary/code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def before_new_version(self, page):
)

if page.key.startswith('/a/') or page.key.startswith('/authors/'):
if page.type.key == '/type/author':
if page.type.key == '/type/author' or page.type.key == '/type/redirect':
return

books = web.ctx.site.things({'type': '/type/edition', 'authors': page.key})
Expand All @@ -118,7 +118,7 @@ def before_new_version(self, page):
'This Author page cannot be deleted as %d record(s) still reference this id. Please remove or reassign before trying again. Referenced by: %s'
% (len(books), books)
)
elif page.type.key != '/type/author' and books:
elif page.type.key not in ['/type/author', '/type/redirect'] and books:
raise ValidationException(
'Changing type of author pages is not allowed.'
)
Expand Down
Loading