fix: Privacy settings radio labels not clickable#11407
Closed
Aniruddhadwivedi07 wants to merge 1 commit intointernetarchive:masterfrom
Closed
fix: Privacy settings radio labels not clickable#11407Aniruddhadwivedi07 wants to merge 1 commit intointernetarchive:masterfrom
Aniruddhadwivedi07 wants to merge 1 commit intointernetarchive:masterfrom
Conversation
When clicking on radio button labels in the Privacy Settings page, the radio buttons were not being selected because the label 'for' attributes did not match their corresponding input 'id' values. This fixes the issue by updating the 'for' attributes to match the correct radio input ids (r0, r1, r2, r3). Fixes #<issue_number>
Collaborator
|
Thanks for your submission, @Aniruddhadwivedi07. Unfortunately, #11385 solved this issue, so I'm going to close this. To avoid this in the future, please ask to be assigned to an issue before working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The radio button labels on the Privacy & Content Moderation Settings page were not functional - clicking them did not select their associated radio buttons.
Fix
Updated the label
forattributes to match their corresponding radio inputidvalues:for="u0"tofor="r0"for public readlog Yesfor="u1"tofor="r1"for public readlog Nofor="u0"tofor="r2"for safe mode Yesfor="u1"tofor="r3"for safe mode NoTesting
forattributes match their radio inputidsu0/u1IDs remainReferences