fix: replace hardcoded URL with dynamic environment-based URL#11410
Merged
cdrini merged 1 commit intointernetarchive:masterfrom Nov 10, 2025
Merged
Conversation
Contributor
Author
|
@cdrini PTAL — replaced the hardcoded URL in the Bulk Search redirect to use a relative path. |
github-actions
bot
added
the
Needs: Response
cdrini
approved these changes
Nov 10, 2025
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Lgtm, thank you @395ShikharSingh .
cdrini
added
Type: Refactor/Clean-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Context:
On the /search/bulk page, clicking the “Add to List” button redirected users to a hardcoded production URL (https://openlibrary.org//account/lists/add?seeds=).
This caused issues during local development, as developers were redirected away from their local environment to the live Open Library site.
Fix:
Replaced the hardcoded URL with a relative path (/account/lists/add?seeds=) so the redirect correctly respects the current environment (e.g., localhost or staging).
Testing:
Verified locally by visiting /search/bulk, performing an extract-match-add flow, and clicking “Add to List” — the redirect now stays within the local instance.
Stakeholders
@cdrini