Fix reading log carousel to check edition-level availability

[Aayushdev18]

When a specific edition is logged in reading logs, fetch availability at the edition level instead of work level. This ensures correct borrow buttons are shown instead of 'Locate' buttons when the logged edition is available.

Fixes #11329

Closes #11329

Fix

Technical

When a reading log entry has a logged edition (from link_editions_to_works), the code now:

• Extracts the edition from the work doc's editions field (handles both list and dict formats)
• Fetches availability using 'openlibrary_edition' mode instead of work-level
• Attaches the edition availability to the work doc for display
• Falls back to work-level availability when no edition is present

Testing

1. Add a book with a specific edition to your reading log (want-to-read, currently-reading, or already-read)
2. Visit /people/your-username/books to see the carousel
3. Verify the borrow button shows correctly for the logged edition (not "Locate" when edition is available)
4. Check that works without logged editions still show correct availability

@cdrini

[cdrini]

You can do this more simply with something like

Suggested change

	want_to_read.docs = add_availability_with_edition_preference(
	want_to_read.docs
	)[:5]
	want_to_read.docs = add_availability(
	[safeget(lambda: d['editions']['docs'][0], d) for d in want_to_read.docs if d.get('title')]
	)[:5]

safeget is a helper method we have for situations just like these!

[cdrini]

Nice, great work @Aayushdev18 ! We can likely simplify this by calling add_availability on the edition directly. That should just work; we do something similar in a few other spots, eg:

openlibrary/openlibrary/templates/work_search.html

Line 98 in 07a4491

$ add_availability([(w.get('editions') or [None])[0] or w for w in works])

The safeget helper should make it a bit more concise!

[cdrini]

Oh good catch! I expect this should only be the dict, but let me know if you find otherwise!

[Aayushdev18]

@cdrini
Thanks for the feedback and suggestion. I've implemented the simplification using safeget as you recommended. Much cleaner reduced from ~50 lines to just 3 lines per carousel.

Regarding the editions structure: I checked the codebase and found that in link_editions_to_works (line 273 in bookshelves.py), it currently sets work_doc.editions = [edition] (as a list). However, I noticed the comment at line 255 mentions doc["editions"]["docs"], suggesting a dict format. So there might be an inconsistency in how editions are structured in different parts of the codebase.

The good news is that using safeget(lambda: d['editions']['docs'][0], d) handles both cases gracefully:
If editions is a dict with docs, it extracts the first edition
If editions is a list, missing, or in a different format, safeget catches the exception and falls back to the work itself (d)
This matches the pattern you showed in work_search.html. The implementation should work regardless of the structure, which is great. If you'd like me to investigate further or standardize the structure, I'm happy to look into it.

Thanks again for the guidance.

[Aayushdev18]

Hi @cdrini, just a gentle follow-up on this PR. All checks have passed , would you be able to take a look when you have time? Thanks!

[cdrini]

Hi @Aayushdev18 ! I tested this, and it seemed to alas not fix the issue! The buttons still displayed "locate". This might need some more debugging, I reckon.

[Aayushdev18]

Hi @cdrini! Thanks for testing. I found the issue: link_editions_to_works sets editions as a list [edition], but the code was only checking the dict format {'docs': [edition]}.
I've updated the code to handle both formats:
If editions is a list, it extracts editions[0]
If editions is a dict, it extracts editions['docs'][0]
This should correctly extract editions, get edition-level availability, and attach it to the work documents. The fix is pushed and ready for testing.
Could you test again when you have a chance? Thanks!

[cdrini]

Hi @Aayushdev18 thanks for the update! I spent some time on this one, and man what a headache to debug! I think you're exactly correct, the editions on the works here are stored as a raw list, not as a {docs: list[dict]} object like in most other places throughout the site. Not sure why the previous solutions didn't fix it, but I tweaked the PR to create a get_editions helper method to specifically handle that ambiguous format. Now it seems to be working on testing; lgtm!