Open
Conversation
cdrini
commented
Nov 7, 2025
| } | ||
|
|
||
|
|
||
| cached_get_betterworldbooks_metadata = cache.memcache_memoize( |
Collaborator
Author
There was a problem hiding this comment.
This looks a bit odd, but I couldn't find any use of this function... CC @mekarpeles
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds type hints to the vendors.py file by introducing TypedDict classes for Better World Books metadata structures and updating function signatures with proper return types.
Key changes:
- Defines
BetterWorldBooksMetadataandBetterWorldBooksMetadataErrorTypedDict classes for structured typing - Updates return type annotations for Better World Books-related functions to use the new TypedDict types
- Removes the cached version of
get_betterworldbooks_metadatafunction
Comments suppressed due to low confidence (1)
openlibrary/core/vendors.py:1
- The removal of
cached_get_betterworldbooks_metadatamay break code that depends on this cached function. This appears to be an unintended deletion rather than a refactoring, as no replacement is provided and the PR description doesn't mention removing caching functionality.
from __future__ import annotations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cdrini
commented
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small addendum to #11379 , adding type hints to vendors.py
Technical
Testing
Screenshot
Stakeholders