Skip to content

fix: mobile dropdown cell height #11477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimchamp merged 11 commits into from
Dec 4, 2025
Merged

fix: mobile dropdown cell height #11477

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a1d5f43
fix: mobile dropdown cell height
akramcodez Nov 17, 2025
36b26c6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 17, 2025
3bc547b
refactor: relocate coarse pointer media query from select to form con…
akramcodez Nov 17, 2025
4b743b7
refactor: adjust form input width styling in form.olform.less
akramcodez Nov 17, 2025
7e44922
Merge branch 'fix/mobile-dropdown-cell-height' into HEAD
akramcodez Nov 17, 2025
ac090c7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 17, 2025
e09944e
refactor: adjust form.olform.less for responsive padding, label width…
akramcodez Nov 17, 2025
d7ca2ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 17, 2025
60a7d5a
Merge branch 'internetarchive:master' into fix/mobile-dropdown-cell-h…
akramcodez Dec 4, 2025
f9fdd5c
refactor: revert unrelated changes, keeping only language autocomplet…
akramcodez Dec 4, 2025
26e0740
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions static/css/components/form.olform.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,12 @@
}
}

select {
@media (pointer: coarse) {
padding: 8px 3px;
min-height: 44px;
}
}
.label {
width: 90%;
}
Expand Down
10 changes: 10 additions & 0 deletions static/css/components/jquery.autocomplete.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,22 @@
&.ac_over {
background-color: @light-yellow;
}

@media (pointer: coarse) {
padding: 12px 5px;
min-height: 44px;
}
}
}

.ac_results .ac_language {
font-size: @font-size-title-medium;
color: @black;

@media (pointer: coarse) {
padding: 12px 5px;
min-height: 44px;
}
}
Comment on lines +49 to 53
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The padding is being applied to the inner .ac_language div, but the parent li element (line 22) already has padding: 5px. This could result in inconsistent spacing. Consider applying the touch target styles directly to the li element using a selector like .ac_results li:has(.ac_language) or applying the styles to .ac_results li with the media query and removing padding from the inner div to avoid double padding.

Suggested change
@media (pointer: coarse) {
padding: 12px 5px;
min-height: 44px;
}
}
@media (pointer: coarse) {
// Move touch target padding/min-height to parent li to avoid double padding
// Remove padding from .ac_language
}
// Apply touch target styles to li containing .ac_language for coarse pointers
@media (pointer: coarse) {
.ac_results li:has(.ac_language) {
padding: 12px 5px;
min-height: 44px;
}
}
}

Copilot uses AI. Check for mistakes.

.ac_author {
Expand Down
5 changes: 5 additions & 0 deletions static/css/page-edit.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ textarea {
font-family: @body-family;
color: @dark-grey;
padding: 5px;

@media (pointer: coarse) {
padding: 8px 5px;
min-height: 44px;
}
}
table.code {
border: 1px solid @grey-e7e7e7;
Expand Down
Loading