Skip to content

Check for sitemaps.log instead of sitemaps directory#11626

Merged
mekarpeles merged 2 commits intomasterfrom
7581/fix/sitemaps-generation
Dec 29, 2025
Merged

Check for sitemaps.log instead of sitemaps directory#11626
mekarpeles merged 2 commits intomasterfrom
7581/fix/sitemaps-generation

Conversation

@mekarpeles
Copy link
Member

Fixes the first part of #7581, correctly implements #11625

Fixes a bug where absence of sitemap directory is preventing sitemaps from being run after --overwrite deletes sitemaps/ directory.

This pull request makes a small change to the sitemap generation logic in scripts/oldump.sh. The script now checks for the existence of the sitemaps.log file instead of the sitemaps directory before generating sitemaps.

Fixes a bug where absence of sitemap directory is preventing sitemaps from being run after `--overwrite` deletes `sitemaps/` directory.

Closes #7581, correctly implements #11625
Copilot AI review requested due to automatic review settings December 25, 2025 15:31
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Dec 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the sitemap generation logic where checking for directory existence was insufficient to determine whether sitemaps needed to be regenerated. The change improves reliability by checking for the actual completion marker (sitemaps.log file) instead of just the directory.

Key Changes:

  • Modified the sitemap generation condition to check for sitemaps.log file instead of the sitemaps/ directory
  • Aligns with the pattern used elsewhere in the script where file existence (rather than directory existence) indicates completion
  • Better handles edge cases where the directory exists but contains no or incomplete sitemap data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member Author

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@mekarpeles mekarpeles merged commit fbad601 into master Dec 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: 1 Do this week, receiving emails, time sensitive, . [managed]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants