Skip to content

Remove unused ia_count Solr field (ref #11586) #11642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bettercallok wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −4
Open

Remove unused ia_count Solr field (ref #11586) #11642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
511aab9
Remove unused ia_count Solr field (ref #11586)
bettercallok Dec 31, 2025
34ef411
Regenerate solr_types.py after removing ia_count
bettercallok Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conf/solr/conf/managed-schema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
<field name="ia" type="string" multiValued="true"/>
<field name="ia_box_id" type="string" multiValued="true"/>
<field name="ia_loaded_id" type="string" multiValued="true"/>
<field name="ia_count" type="pint"/>

<field name="ia_collection" type="string" multiValued="true" />
<field name="oclc" type="text_en_splitting" multiValued="true"/>
<field name="isbn" type="string" multiValued="true"/>
Expand Down
2 changes: 0 additions & 2 deletions openlibrary/plugins/worksearch/schemes/works.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ class WorkSearchScheme(SearchScheme):
"publish_year",
"language",
"number_of_pages_median",
"ia_count",
"publisher_facet",
"author_facet",
"first_publish_year",
Expand Down Expand Up @@ -165,7 +164,6 @@ class WorkSearchScheme(SearchScheme):
'currently_reading': 'currently_reading_count desc',
'already_read': 'already_read_count desc',
'title': 'title_sort asc',
'scans': 'ia_count desc',
# Classifications
'lcc_sort': 'lcc_sort asc',
'lcc_sort asc': 'lcc_sort asc',
Expand Down
1 change: 0 additions & 1 deletion openlibrary/solr/solr_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ class SolrDocument(TypedDict):
ia: Optional[list[str]]
ia_box_id: Optional[list[str]]
ia_loaded_id: Optional[list[str]]
ia_count: Optional[int]
ia_collection: Optional[list[str]]
oclc: Optional[list[str]]
isbn: Optional[list[str]]
Expand Down
Loading