Add missing translation. Fixes #12187#12188
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a missing translation on the language detail page by using the already-localized language display name instead of the raw page.name field.
Changes:
- Replace
$page.namewith$namefor the “Name” field so the displayed value matches the localized title.
cdrini
left a comment
There was a problem hiding this comment.
Lgtm, confirmed worked on testing for various locales. I wonder if we might want to remove this entirely if it's just duplicating the name? Or maybe have it be "Native Name" and have it render that instead? 🤷♂️
I don't have a strong preference, but note that the page title potentially has the string "[Deprecated]" appended, so it's not actually identical. Autonym is an interesting thought, but probably not as useful here as someplace like the language selector where users are scanning the list for their own language. |
Closes #12187
fix
Technical
Fixes missing translation on language page. I chose to use the simple name without the [Deprecated] tag which appears in the page title.
Testing
Copy https://openlibrary.org/languages/ger.yml to http://localhost:8080/languages/ger.yml?m=edit
Set UI language to français
Visit http://localhost:8080/languages/ger
Screenshot
Stakeholders