Skip to content

Add missing translation. Fixes #12187#12188

Merged
cdrini merged 1 commit intointernetarchive:masterfrom
tfmorris:12187-language-page-i18n
Mar 31, 2026
Merged

Add missing translation. Fixes #12187#12188
cdrini merged 1 commit intointernetarchive:masterfrom
tfmorris:12187-language-page-i18n

Conversation

@tfmorris
Copy link
Copy Markdown
Contributor

Closes #12187

fix

Technical

Fixes missing translation on language page. I chose to use the simple name without the [Deprecated] tag which appears in the page title.

Testing

Copy https://openlibrary.org/languages/ger.yml to http://localhost:8080/languages/ger.yml?m=edit
Set UI language to français
Visit http://localhost:8080/languages/ger

Screenshot

Screenshot 2026-03-24 at 19 23 21

Stakeholders

Copilot AI review requested due to automatic review settings March 24, 2026 23:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a missing translation on the language detail page by using the already-localized language display name instead of the raw page.name field.

Changes:

  • Replace $page.name with $name for the “Name” field so the displayed value matches the localized title.

Copy link
Copy Markdown
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, confirmed worked on testing for various locales. I wonder if we might want to remove this entirely if it's just duplicating the name? Or maybe have it be "Native Name" and have it render that instead? 🤷‍♂️

@cdrini cdrini merged commit 668851c into internetarchive:master Mar 31, 2026
6 of 7 checks passed
@tfmorris tfmorris deleted the 12187-language-page-i18n branch March 31, 2026 21:35
@tfmorris
Copy link
Copy Markdown
Contributor Author

I wonder if we might want to remove this entirely if it's just duplicating the name? Or maybe have it be "Native Name" and have it render that instead? 🤷‍♂️

I don't have a strong preference, but note that the page title potentially has the string "[Deprecated]" appended, so it's not actually identical.

Autonym is an interesting thought, but probably not as useful here as someplace like the language selector where users are scanning the list for their own language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing translation on language page

3 participants