Redirect DAISY pages to Archive item pages#13049
Open
nathanpixodeo wants to merge 2 commits into
Open
Conversation
Collaborator
|
Thank you @nathanpixodeo for submitting this issue! Welcome to Open Library — this is your first contribution! 🎉 🤖 Copilot has been assigned for an initial review. A reviewer must first be assigned. There are currently 104 open non-draft PRs of equal or higher priority ahead of yours. PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #9439
Fixes the stale
/books/.../daisyflow by redirecting editions with anocaidto their Internet Archive item page instead of rendering the old page with a guessed_daisy.zipdownload URL.Technical
https://archive.org/details/{ocaid}when an edition has an Archive identifier.ocaidfallback page behavior.Testing
python -m py_compile openlibrary/plugins/upstream/addbook.py openlibrary/plugins/upstream/tests/test_addbook.pypython -m ruff check openlibrary/plugins/upstream/addbook.py openlibrary/plugins/upstream/tests/test_addbook.pyopenlibrary/core/helpers.pyare evaluated differently.Screenshot
Not applicable; this is a redirect behavior change.
Stakeholders
@mekarpeles