fix: resolve volumes multiget endpoint failing with .json extension#13093
Open
RsbhThakur wants to merge 1 commit into
Open
fix: resolve volumes multiget endpoint failing with .json extension#13093RsbhThakur wants to merge 1 commit into
RsbhThakur wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the PR, @RsbhThakur! The linked issue hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 30 open non-draft PRs ahead of yours. PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. — Richy, via PAM (Open Library's Project AI Manager) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13092
fix
Technical
MULTIGET_PATH_RE) inget_volumes_multiget(inopenlibrary/fastapi/books.py). FastAPI/Starlette already parses thereqparameter and automatically strips the.jsonextension from the URL.reqparameter toreadlinks.readlinks(req, {}).import reandimport urllib.parseat the top ofbooks.py(cleaned up automatically via Ruff linter).TestGetVolumesMultigetinopenlibrary/tests/fastapi/test_books.pyto assert the exact arguments passed to the mockedreadlinksfunction, eliminating mock testing gaps and preventing future regressions.Testing
.jsonextension:Actual (Before): Returned
{}empty response.Screenshot
N/A (This is a backend API bug fix).