Fix: Added want to read button on trending page#13120
Open
dvvrtmshra wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the PR, @dvvrtmshra! @mekarpeles is assigned to this PR and currently has:
PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. |
65fd896 to
3386bd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12810
Technical
The
SearchResultsWorkmacro call intrending.htmlwas missing theinclude_dropper=Trueparameter, so the reading-log widget (which renders the "Want to Read" button) was never rendered on trending pages. Every other listing page that shows this widget (work_search.html,type/author/view.html,type/list/view_body.html) already passes this flag.Added
include_dropper=Trueto the macro call atopenlibrary/templates/trending.html:31. No changes needed elsewhere — the dropper usesasync_load=Trueinternally, so reading-log state is fetched client-side, and trending pages already provide Solr work documents via thesolr_workcode path inSearchResultsWork.html.Testing
/trending/now./search)./trending/daily,/trending/weekly,/trending/yearly) to confirm the button appears there too./trending/nowto confirm logged-out behavior is unaffected/consistent with other listing pages.Stakeholders