upgrade vue-muliselect to beta for Vue 3 support#8384
Closed
RayBB wants to merge 2 commits intointernetarchive:masterfrom
Closed
upgrade vue-muliselect to beta for Vue 3 support#8384RayBB wants to merge 2 commits intointernetarchive:masterfrom
RayBB wants to merge 2 commits intointernetarchive:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ee2b7c2 to
a6ac071
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8384 +/- ##
=======================================
Coverage 17.44% 17.44%
=======================================
Files 89 89
Lines 4792 4792
Branches 848 848
=======================================
Hits 836 836
Misses 3436 3436
Partials 520 520 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Updated to the new non-beta version and it works well. |
1 task
Collaborator
Author
Collaborator
Collaborator
Author
|
This will never work because we need everything upgraded at once. Closing in favor of #10298 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Contributes to #7547
Upgrades vue-multiselect to beta version for Vue 3 support.
According to the docs here the main change is that:
But we don't use
inputin the muliselect right now so we should have no problems.Technical
Using isn't ideal but it's better than migrating to another component right now.
Testing
Use language selector in library explorer.
Screenshot
Stakeholders