feat: add MigrationContext and Migration Summary Report #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea with this MigrationContext, but I don't like the implementation as a "singleton". My suggestion would be to create one Context at the beginning an pass it as additional parameter to the migrateProject(s) methods. |
Thanks for the feedback I will adapt the current implementation accordingly and if this is indeed the way to go for the migration summary I will implement this in the other migrators as well. |
fgiesske-intershop
force-pushed
the
feature/add-summary-report
branch
2 times, most recently
from
05abc24 to
e28c119
Compare
rowiish
requested changes
May 23, 2025
migration/src/main/java/com/intershop/customization/migration/Migrator.java
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/Migrator.java
Outdated
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/common/MigrationPreparer.java
Outdated
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/file/MoveFolder.java
Outdated
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/common/MigrationContext.java
Outdated
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/common/MigrationContext.java
Outdated
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/common/MigrationContext.java
Outdated
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/common/MigrationContext.java
Outdated
Show resolved
Hide resolved
fgiesske-intershop
force-pushed
the
feature/add-summary-report
branch
2 times, most recently
from
0ffebee to
9d103b0
Compare
fgiesske-intershop
force-pushed
the
feature/add-summary-report
branch
2 times, most recently
from
1764548 to
431736d
Compare
rowiish
reviewed
May 26, 2025
migration/src/main/java/com/intershop/customization/migration/common/MigrationPreparer.java
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/file/MoveFolder.java
Show resolved
Hide resolved
migration/src/main/java/com/intershop/customization/migration/gradle/ConvertToKotlin.java
Show resolved
Hide resolved
fgiesske-intershop
force-pushed
the
feature/add-summary-report
branch
from
530c3bd to
6cd3064
Compare
fgiesske-intershop
requested review from
rowiish and
SteBoe82
and removed request for
SteBoe82
rowiish
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft version for a Migration Summary Report, currently work in progress!