feature/convert-preference-config #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look at the java doc. They contains a lot of typos :-( Our customers and partners will use this migrator... |
|
MigrateConfigResources, line 44: duplicate condtion |
|
Remove obsolete private methods "isEmpty(Path)" and "delete(Path)". |
|
MigrateConfigResources, Line 54: Stream not closed |
rowiish
reviewed
May 23, 2025
|
Please add a Commit Message to |
Just tell they are there. |
The closure is in line 111 }); or am I wrong? |
Correct |
hmordt-ish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conversion of managed services and domain preference configurations, stream line resource type mappings, comments and formatting