Skip to content

Show servers defined in workspace folder settings in UI#273

Merged
isc-bsaviano merged 5 commits into
intersystems-community:masterfrom
isc-bsaviano:fix-272
May 28, 2025
Merged

Show servers defined in workspace folder settings in UI#273
isc-bsaviano merged 5 commits into
intersystems-community:masterfrom
isc-bsaviano:fix-272

Conversation

@isc-bsaviano
Copy link
Copy Markdown
Collaborator

This PR fixes #272. I will tackle the "Add Server" command item in a separate PR because it's an enhancement.

@isc-bsaviano
Copy link
Copy Markdown
Collaborator Author

@gjsjohnmurray I am not sure how to publish a new version of the types to get the CI to pass.

@gjsjohnmurray
Copy link
Copy Markdown
Collaborator

I have drafted PR #275 and published @intersystems-community/intersystems-servermanager@3.10.2-beta.1 on npmjs.com

Please update package.json in your PR to use that beta, which I hope will fix the CI failure. Assuming it does, and no more changes are required in types/index.d.ts to complete your PR, I will update mine to remove the beta tag, publish 3.10.2 and ask you to approve my PR. Then you should be able to yours to remove the -beta.1 suffix on the devDependencies line.

@gjsjohnmurray
Copy link
Copy Markdown
Collaborator

Now ready for your change to the devDependencies line, removing the -beta.1 suffix. Please also update your branch from master.

@gjsjohnmurray
Copy link
Copy Markdown
Collaborator

Do you want to get the dev VSIX validated by the customer who raised the issue?

@isc-bsaviano
Copy link
Copy Markdown
Collaborator Author

@gjsjohnmurray I will double-check this myself before merging.

@isc-bsaviano
Copy link
Copy Markdown
Collaborator Author

This looks good to me. The workspace folder specific servers do not appear in the "All Servers" tree, just "Current". I think that is fine for now and I will attempt to address that in a separate PR.

@isc-bsaviano isc-bsaviano merged commit 04f04da into intersystems-community:master May 28, 2025
3 checks passed
@isc-bsaviano isc-bsaviano deleted the fix-272 branch May 28, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server tree does not behave when server definitions are at the workspace folder level

2 participants