Support choosing settings scope for Add Server command#274
Merged
isc-bsaviano merged 2 commits intoMay 29, 2025
Conversation
Collaborator
Author
|
@gjsjohnmurray Any comments? I would like to get this merged by early next week so we can do a 3.10.2 release. |
gjsjohnmurray
approved these changes
May 29, 2025
Collaborator
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
Looks fine. I only did minimal testing, but happy to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.