Skip to content

Small tweaks #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged

Conversation

isc-bsaviano
Copy link
Contributor

This PR arose during my investigation of #1537 for server-side editing.

  • Fire file change events for related documents that were updated by compilation.
  • Remove unneeded cache clearing before firing file change events and refresh of server-side class that's open in a low-code editor. VS Code's calling of stat() will cause the file to update in these cases.
  • Remove unneeded workspaceState updates from FileSystemProvider. This is a client-side feature.
  • Fire file create events when creating files via writeFile()or rename().
  • Don't allow rename() to overwrite a file that's marked read-only by source control or due to being deployed.
  • Don't allow using client-side "import and compile" commands with server-side files.
  • Hide some commands when the active text editor is dirty.

@gjsjohnmurray I've tested this a bunch but I would appreciate you playing with it for a little bit just to make sure it's good.

@gjsjohnmurray
Copy link
Contributor

@isc-bsaviano OK, I have installed the dev VSIX. My usage will likely be exclusively server-side, so that's the scenario I'll be testing.

@isc-bsaviano
Copy link
Contributor Author

@gjsjohnmurray How does this look? I would like to get these last two PRs merged soon do I can do a 3.0.2 release next week.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used the dev VSIX for a couple of days (server-side paradigm only) and not seen any problems, so am approving this.

@isc-bsaviano
Copy link
Contributor Author

Thanks John!

@isc-bsaviano isc-bsaviano merged commit 351f58c into intersystems-community:master May 9, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the server-1537 branch May 9, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants