Address syntax, style, and functional issues #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recommend reviewing this diff while ignoring whitespace changes. This commit brings `objectscript_udl-ts-mode.el' into compliance with typical Lisp style. No functional changes are made in this commit.
The `autoload` form is generated automatically when package.el builds this package (as it scans for these cookies); specifying it manually is atypical. See `(info "(elisp) Autoload")` for more details.
`use-package` has known the `:vc` keyword for a few years now. Use it in the installation instructions to drastically simplify what it advertised -- even before this package is added to MELPA.
vermiculus
force-pushed
the
sa/fix-syntax
branch
from
3cbe543 to
dfd175d
Compare
vermiculus
changed the title
At [1], we can see that the 'udl' variant simply uses `tree_sitter_objectscript` as the exported symbol. If we call the language `objectscript_udl` in `treesit-language-source-alist`, Emacs will look for `tree_sitter_objectscript_udl`, which does not exist. Rename the language to `objectscript` so that the correct symbol is identified and found. [1]: https://github.com/intersystems/tree-sitter-objectscript/blob/4d34cb2d4a4924f0b9c9524ffaba1b9c0644067e/setup.py#L12
Just for ease of use.
vermiculus
force-pushed
the
sa/fix-syntax
branch
from
dfd175d to
f85bf49
Compare
Author
|
By the way, have you been able to get this to build / load recently? I consistently get (for example) Luckily d587ce8c65a (Support Tree-sitter version 0.26 and later, 2025-10-17) dropped on master recently which looks like it adds support for ABI 15, but I'm wondering if I'm just new to the treesitter game. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Very interested to see if I can get this working on my system; thanks for throwing this together :-)