[scd] Store past OVNs on operational intents upsert #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmis
force-pushed
the
1078/pastovns
branch
3 times, most recently
from
998a450 to
4a3db8c
Compare
Shastick
approved these changes
Sep 3, 2024
|
Side thought: if the parent PR still needs a bit of work, the current refactoring effort (#1088) would benefit from the change of (Otherwise I could also do so) |
mickmis
force-pushed
the
1078/pastovns
branch
from
4a3db8c to
beb2042
Compare
barroco
approved these changes
Sep 9, 2024
7 tasks
mickmis
force-pushed
the
1078/pastovns
branch
from
beb2042 to
7e0e531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR stacked on top of #1095 and #1100: please only consider beb2042 for review.
Continuation of #1078
This enables storing all past OVNs in the DB.