-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(unplugin-vue-i18n): ts files load #434
base: main
Are you sure you want to change the base?
Conversation
node版本太低对应的corepack太低导致此,需要corepack最新版本就能解决pnpm签名问题 |
Could you fix the CI fails? 🙏 |
|
@@ -10,7 +10,7 @@ import type { MessageCompilerContext } from '@intlify/core-base' | |||
fixture: '@intlify/unplugin-vue-i18n/messages' | |||
} | |||
].forEach(({ testcase, input, fixture }) => { | |||
test(testcase, async () => { | |||
test.skip(testcase, async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you skip this test case? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I follow this file packages\unplugin-vue-i18n\test\webpack\bundle-import.test.ts to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand the test cases here, so I found that there is a problem with skip handling under webpack. I think there is a problem, but I don't know how to solve it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, This is so weird...
I made a test PR to see if I could reproduce this phenomenon, but I couldn't.
#440
Could you re-send your PR from latest commits please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resubmit
d47fc38
to
985ad2c
Compare
Hi! |
We likely need to remove the types from typescript files before passing it to the Perhaps we need something like |
Since these two files cannot be parsed into the desired AST using the generateJavascript method, they are temporarily unsupported. I will look into how to handle these cases in the future.
|
It would be better to keep the test fixtures as they originally were, and prevent loading The changes in it its current state might suggest to users that we support loading |
Most projects nowadays are TypeScript-based, so removing TypeScript doesn’t seem appropriate. I will consider how to resolve these two cases. |
fix: TS files are not loaded (@intlify/unplugin-vue-i18n/messages)