fix: virtual bundle for webpack #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbieGoede
added
Type: Performance
BobbieGoede
commented
Mar 9, 2025
| ...opts, | ||
| filename, | ||
| sourceMap, | ||
| jit, | ||
| jit: true, |
There was a problem hiding this comment.
@kazupon
While refactoring it seemed like all option passing eventually resulted in jit: true being passed, is this correct?
BobbieGoede
changed the title
|
I did some more refactoring on this branch, I think the virtual bundle/resource didn't work for webpack earlier? 🤔 It now works with these changes, I have re-enabled the Unfortunately, reload on locale file change only works for vite and webpack, not sure how to get that working for rspack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More refactoring! This narrows the type returned by resolved options and changes the way default values are applied to the user input.
More changes have been made to improve type inference/safety and I have replaced async fs function calls with synchronous calls.
I hope the tests cover enough to catch if I made any mistakes... 🫣