fix: remove useless finally

[eric-intuitem]

Was provoking a warning

Summary by CodeRabbit

• Refactor
  • Enhanced SAML authentication error handling and redirect flow to improve error reporting and user navigation during the login process.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The SAML views redirect logic was restructured, moving finalization operations from a finally block into the post-exception handling flow. This changes when error query parameters are appended and ensures email verification checks occur only on the successful user path before final redirection.

Changes

Cohort / File(s)	Summary
SAML redirect logic restructuring backend/iam/sso/saml/views.py	Relocated redirect and finalization operations from finally block to sequential post-except flow; error query parameter appending and email verification block now occur only after exception handling during normal completion

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 A flow restructured, now clean and neat,
From finally blocks to sequential beat,
Errors handled first, then redirect's call,
The rabbit hops through it all! 🌿

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: remove useless finally' accurately describes the main change: removing an unnecessary finally block from the code.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89cd80f and 4d89959.

📒 Files selected for processing (1)

• backend/iam/sso/saml/views.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: startup-docker-compose-test
• GitHub Check: enterprise-startup-docker-compose-test
• GitHub Check: startup-functional-test (3.12)
• GitHub Check: test (3.12)
• GitHub Check: build (3.12)
• GitHub Check: enterprise-startup-functional-test (3.12)
• GitHub Check: build_enterprise_frontend
• GitHub Check: build_community_frontend
• GitHub Check: Analyze (python)

[nas-tabchiche]

LGTM