Add fallback directories to find stdio command. #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemang-snyk
force-pushed
the
check-well-known-dirs
branch
from
73304dc to
d399dd0
Compare
hemang-snyk
force-pushed
the
check-well-known-dirs
branch
from
d399dd0 to
6b86c45
Compare
mmilanta
requested changes
Dec 22, 2025
Contributor
mmilanta
left a comment
mmilanta
left a comment
There was a problem hiding this comment.
It looks good,
Can you make sure the same logic is used when checking if the binary is signed? Here: src/mcp_scan/signed_binary.py
…lve_command_and_args to utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing some errors with Path not found. Example:
Traceback (most recent call last):\n File "mcp_scan/MCPScanner.py", line 224, in scan_server\n File "mcp_scan/mcp_client.py", line 204, in check_server\n File "asyncio/tasks.py", line 507, in wait_for\n File "mcp_scan/mcp_client.py", line 193, in _check_server_pass\n File "mcp_scan/mcp_client.py", line 141, in _check_server\n File "contextlib.py", line 214, in aenter\n File "mcp_scan/mcp_client.py", line 87, in get_client\nValueError: Path does not exist: docker\n"
Attempting to look for the command in a list of directories as a fallback mechanism.