global: item revision endpoint #63
Conversation
|
Things to consider:
|
mvesper
force-pushed
the
gim_third_revision_endpoint
branch
2 times, most recently
from
c7e60fb to
adbc09f
Compare
invenio_circulation/config.py
Outdated
| }, | ||
| 'crcrev': { | ||
| 'default_endpoint_prefix': True, | ||
| 'pid_type': 'crcrev', |
There was a problem hiding this comment.
Do you have a new pid_type or can you use the 'crcitm'?
mvesper
force-pushed
the
gim_third_revision_endpoint
branch
3 times, most recently
from
695f0da to
c5b368d
Compare
david-caro
left a comment
david-caro
left a comment
There was a problem hiding this comment.
Looks ok, have a couple of 'questions' there though.
| output = json.loads( | ||
| subprocess.check_output(cmd, shell=True).decode('utf-8') | ||
| ) | ||
| assert output and 'hits' in output and 'hits' in output['hits'] |
There was a problem hiding this comment.
Shouldn't you check the amount of hits? (not sure if it's relevant though, maybe just the fact that the hits key is there means that there have been some)
There was a problem hiding this comment.
Maybe even compare it to the expected dict like you do in the other test:
assert output == {
'hits': {
'hits': ...
}
}There was a problem hiding this comment.
Ah, yes, you are correct :). But in order to make this happen I'd also have to change the examples.app:items to create better fixtures. Since this PR grew quite a little already, maybe we can do this later.
Right now we just check that the endpoint is there.
There was a problem hiding this comment.
Sure, just make sure to open an issue on it just to not forget about it.
| item_revision_search = ItemRevisionSearch() | ||
|
|
||
| assert item_revision_search == item_revision_search[0] | ||
| assert item_revision_search == item_revision_search.params() |
There was a problem hiding this comment.
Our search classes subclass elasticsearch_dsl.Search (at least invenio_search.RecordsSearch does) and this class has the methods __getitem__ and params that I had to mock for the desired functionality.
Those functions perform some changes (__getitem__ for example uses slicing for pagination) and then return themselves :)
|
LGTM |
invenio_circulation/search.py
Outdated
| from elasticsearch_dsl.query import Bool, MultiMatch, Range | ||
|
|
||
| from invenio_search import RecordsSearch | ||
| from invenio_circulation.api import Item |
There was a problem hiding this comment.
@mvesper is the isort enabled in /run-tests.sh?
Normally, we use relative imports for current package, hence from .api import Item. In anycase there should be an empty line before block of imports from current language. Just check it with isort invenio_circulation/search.py.
There was a problem hiding this comment.
isort is on and I changed it to relative import :)
mvesper
force-pushed
the
gim_third_revision_endpoint
branch
from
c5b368d to
269d44c
Compare
|
Looks good to me :) |
mvesper
changed the title
mvesper
force-pushed
the
gim_third_revision_endpoint
branch
from
269d44c to
12a5e36
Compare
jirikuncar
left a comment
jirikuncar
left a comment
There was a problem hiding this comment.
LGTM
--
Since it is already 2017, can you update copyrights in files you have touched?
mvesper
force-pushed
the
gim_third_revision_endpoint
branch
from
12a5e36 to
69c8a37
Compare
|
@jirikuncar Changed the copyrights :) |
|
@mvesper you should just add 2017 and keep 2016. |
* Adds the endpoint configuration for `Item.find_by_holding`. Signed-off-by: Martin Vesper <[email protected]>
mvesper
force-pushed
the
gim_third_revision_endpoint
branch
from
69c8a37 to
a2c2a18
Compare
|
@jirikuncar x) fixed |
4 participants
Item.find_by_holding.