fix: don't allow email aliases on registration - #573
Open
ciurana-life wants to merge 1 commit into
Open
Conversation
* It was possible to re-send the account creation email to a registered user using an alias * Combined with injecting a url on the email this was a problem * No impact on account creation since no email provider allows normal accounts to contain "+" when creating them Signed-off-by: Victor Ciurana <victor.ciurana.loeffler@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue reported at https://github.com/zenodo/ops/issues/537#event-30039858466
Related to fix: Prevent html injection in ProfileForm invenio-userprofiles#202
It was possible to re-send the account creation email to a registered user using an alias
Combined with injecting a url on the email this was a problem
No impact on account creation since no email provider allows normal accounts to contain "+" when creating them
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: