Closings: Added endpoint to return date ranges during which a location is closed #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobMiesner
force-pushed
the
feature/closings
branch
from
b058ef7 to
b8f1af4
Compare
JakobMiesner
force-pushed
the
feature/closings
branch
from
b8f1af4 to
805d215
Compare
ntarocco
reviewed
May 15, 2025
Contributor
ntarocco
left a comment
ntarocco
left a comment
There was a problem hiding this comment.
LGTM! 👏🏼 Great work and very clean!
Co-authored-by: Nicola <[email protected]>
Co-authored-by: Nicola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CERNDocumentServer/cds-ils#967