update dependencies #1241
Merged
update dependencies #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix user deletion trying to delete UserProfile * UserProfile is not a db model since invenio-userprofiles v2.0
…ersion * UserProfile creation is no longer separate from User creation * UserProfile is only needed for patron1
JakobMiesner
force-pushed
the
feature/update-dependencies
branch
from
1f6994f to
49dbd86
Compare
* UserProfile is no longer a model
* after the invenio-app update RATELIMIT_STORAGE_URL was renamed to RATELIMIT_STORAGE_URI
* after the flask>=3 update APP_ALLOWED_HOSTS was renamed to TRUSTED_HOSTS
* after the marshmallow 3.13 update `default` was replaced by `load_default`
JakobMiesner
force-pushed
the
feature/update-dependencies
branch
from
1cd3756 to
42a3d3b
Compare
kpsherva
reviewed
Jul 25, 2025
| @@ -0,0 +1,103 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
workaround for invenio-theme to use as is. It expects this file to be present
kpsherva
reviewed
Jul 25, 2025
| patron_loans = dump(get_loans_by_patron_pid(patron_pid)) | ||
|
|
||
| patron_profile = UserProfile.get_by_userid(patron_pid).__dict__ | ||
| del patron_profile["_sa_instance_state"] |
Contributor
There was a problem hiding this comment.
what was the conclusion for this change? safe to remove?
Contributor
Author
There was a problem hiding this comment.
Since the profile is no longer a standalone table, but a JSON column in the users table, it does not have the _sa_instance_state field anymore. The field is something SQLAlchemy adds to ORM instances
JakobMiesner
force-pushed
the
feature/update-dependencies
branch
from
97d9ed5 to
1aa49ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: CERNDocumentServer/cds-ils#1006
tests are failing because it depends on PRs for dependent packages to be merged (e.g. inveniosoftware/invenio-pidrelations#32).
See the PRs in the issue linked above