permissions: add backoffice readonly action and permission #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobMiesner
force-pushed
the
feature/permissions/readonly-librarian
branch
2 times, most recently
from
daf09b2 to
4f1b44f
Compare
* add `backoffice_readonly_access_action` and have it replace `backoffice_access_action` in read operations * Users with the `backoffice_readonly_access_action` can read everything that users with the `backoffice_access_action` could read before * create `PatronOwnerReadPermission` and `backoffice_read_permission` that make use of `backoffice_readonly_access_action`
…s into read permssion * renamed `send-notification-to-patron` into `get-notifications-sent-to-patron` * declare it as backoffice read permission
JakobMiesner
force-pushed
the
feature/permissions/readonly-librarian
branch
from
4f1b44f to
0a77e67
Compare
kpsherva
reviewed
Sep 26, 2025
| } | ||
| ) | ||
| @need_permissions("send-notification-to-patron") | ||
| @need_permissions("get-notifications-sent-to-patron") |
Contributor
There was a problem hiding this comment.
thanks for renaming this, much more clear this way
kpsherva
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the permission system to allow for readonly-librarians.
backoffice_readonly_access_actionand have it replacebackoffice_access_actionin read operationsbackoffice_readonly_access_actioncan read everything that users with thebackoffice_access_actioncould read beforePatronOwnerReadPermissionandbackoffice_read_permissionthat make use ofbackoffice_readonly_access_actionsend-notification-to-patronintoget-notifications-sent-to-patron, as it is only used for reading notificationscloses: CERNDocumentServer/cds-ils#969