stats: Purchase Orders #1262
Merged
stats: Purchase Orders #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobMiesner
force-pushed
the
feature/stats/orders
branch
7 times, most recently
from
2c15aac to
176300b
Compare
JakobMiesner
force-pushed
the
feature/stats/orders
branch
from
176300b to
5784201
Compare
kpsherva
reviewed
Jan 6, 2026
kpsherva
reviewed
Jan 6, 2026
kpsherva
reviewed
Jan 6, 2026
| _VALID_DATE_INTERVALS = {"1d", "1w", "1M", "1q", "1y"} | ||
|
|
||
|
|
||
| def validate_field_name(field_name): |
Contributor
There was a problem hiding this comment.
is this function reused somewhere outside the SecureFieldName?
Contributor
Author
There was a problem hiding this comment.
You are right. Moved it inside SecureFieldName
kpsherva
reviewed
Jan 6, 2026
kpsherva
reviewed
Jan 6, 2026
kpsherva
reviewed
Jan 6, 2026
kpsherva
reviewed
Jan 6, 2026
kpsherva
reviewed
Jan 6, 2026
kpsherva
reviewed
Jan 6, 2026
JakobMiesner
force-pushed
the
feature/stats/orders
branch
from
5784201 to
fbb7b0f
Compare
* the endpoint returns a histogram for stats where requested metrics are grouped by and aggregated * extend the orders index with a new stats object * the stats object contains order_processing_time and document_request_waiting_time
* validation should be handled by passing the validate param, not in the deserialization
JakobMiesner
force-pushed
the
feature/stats/orders
branch
from
fbb7b0f to
824fb24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: CERNDocumentServer/cds-ils#1034