Skip to content

Conversation

@ptamarit
Copy link
Member

❤️ Thank you for your contribution!

Description

Fixes #2919
See description in the linked issue.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a sensible change. The only thought I have is a lot of the other fields seem to deal with escaping in the ui serializer. Not sure if it makes sense to fix this upstream instead.

@alejandromumo alejandromumo merged commit 9d9664d into inveniosoftware:master Nov 22, 2024
4 checks passed
@ptamarit ptamarit deleted the 2919-bugfix-journal-title-double-escape branch November 22, 2024 14:37
@ptamarit
Copy link
Member Author

Looks like a sensible change. The only thought I have is a lot of the other fields seem to deal with escaping in the ui serializer. Not sure if it makes sense to fix this upstream instead.

@tmorrell are you referring to SanitizedUnicode? Not sure to understand, because this is already used for the journal title field.
In this case, the problem is that React is escaping text, and react-i18n is also escaping the text, causing double escaping and displaying of HTML entities.

@tmorrell
Copy link
Contributor

@ptamarit Yeah, I was wondering why it wasn't needed for other fields like description and title, but it's because those aren't run through i18n. Thanks for the explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Journal title double escaped

3 participants