Skip to content

Conversation

@0einstein0
Copy link
Member

@0einstein0 0einstein0 commented Nov 22, 2024

❤️ Thank you for your contribution!

Description

Fixes Issue inveniosoftware/invenio-vocabularies#433

Screenshot 2024-11-22 at 11 35 30

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.


APP_RDM_IDENTIFIER_SCHEMES_UI = {
"orcid": {
"url_prefix": "http://orcid.org/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"url_prefix": "http://orcid.org/",
"url_prefix": "https://orcid.org/",

shelve: although I think we need see how we can maybe take advantage of the existing data to get the URL, and avoid Jinja shenanigans

@slint slint merged commit 61f87db into inveniosoftware:master Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import EDMO organizations into the affiliations vocabulary

2 participants